Default Retention Policy incorrectly auto created #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🚢 |
corylanou
added a commit
that referenced
this pull request
Mar 12, 2015
Default Retention Policy incorrectly auto created
|
We have an integration test specifically for this. I'm looking into why it didn't catch it. |
|
I see now. The command 'SHOW RETENTION POLICIES' is unaffected by this bug, since it doesn't depend on the key in the map. I wonder why we we even bother use a map to store retention policies. @corylanou -- good catch. How did you come across it? |
|
@otoolep when I added the graphite auto create database, I let it auto create the rp for me, and it kept failing telling me it couldn't find the default retention policy. As a follow up I'm changing the "show retention policies foo" to send back a new column "default". |
|
Good idea. I presume you mean a Boolean column. |
mark-rushakoff
pushed a commit
that referenced
this pull request
Jan 11, 2019
* Fix typo * Add logout route and component * Refactor logout button in profile to point to logout route * WIP refactor nav menu Making the presentational components composable, removed a couple unecessary concepts * Style sub-menu items * Remove unecessary async * Use Clockface Select to enforce child types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs:
Added test coverage for these scenarios.